Skip to content

sort list of codefi assets#8887

Merged
bergarces merged 9 commits into
mainfrom
correct-price-api-list
May 26, 2026
Merged

sort list of codefi assets#8887
bergarces merged 9 commits into
mainfrom
correct-price-api-list

Conversation

@bergarces
Copy link
Copy Markdown
Contributor

@bergarces bergarces commented May 21, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Data-only updates to chain→CAIP-19 mappings for token pricing; no auth or transaction logic, with a targeted fix for Blast lookups.

Overview
Updates SPOT_PRICES_SUPPORT_INFO in codefi-v2.ts so CodeFi Price API v3 spot prices align with supported EVM chains.

Adds inEVM Mainnet (0x9dd / chain 2525) and ICB Network (0x11d9b / chain 73115) with zero-address native ERC-20 CAIP-19 IDs.

Fixes Blast Mainnet’s map key from 0x13c31 to 0x13e31 so native ETH price lookups stop failing silently.

Reorders entries by chain ID, clarifies that the list is only for the spot-prices endpoint (with a note to verify API responses before adding chains), and lightly reorders chainIdToNativeTokenAddress without changing behavior. Changelog documents the add/fix under [Unreleased].

Reviewed by Cursor Bugbot for commit d2f990b. Bugbot is set up for automated code reviews on this repo. Configure here.

@bergarces bergarces requested a review from a team as a code owner May 21, 2026 20:50
@bergarces bergarces temporarily deployed to default-branch May 21, 2026 20:50 — with GitHub Actions Inactive
'0x11d9b': 'eip155:73115/erc20:0x0000000000000000000000000000000000000000', // ICB Network - Native symbol: ICBX,
'0x138de': 'eip155:80094/erc20:0x0000000000000000000000000000000000000000', // Berachain - Native symbol: Bera',
'0x13c31': 'eip155:81457/slip44:60', // Blast Mainnet - Native symbol: ETH
'0x13e31': 'eip155:81457/slip44:60', // Blast Mainnet - Native symbol: ETH
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one had a typo in the key.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reordered the object keys, added a couple of missing chains for which we have support and removed one that had no prices (other than Tempo, which is a valid exception as there's no native asset).

@bergarces bergarces requested a review from a team as a code owner May 21, 2026 20:59
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f9217ec. Configure here.

Comment thread packages/assets-controllers/src/token-prices-service/codefi-v2.ts
@bergarces bergarces changed the title correct list of codefi assets sort list of codefi assets May 26, 2026
@bergarces bergarces added this pull request to the merge queue May 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 26, 2026
@bergarces bergarces added this pull request to the merge queue May 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 26, 2026
@bergarces bergarces added this pull request to the merge queue May 26, 2026
Merged via the queue into main with commit 9537eee May 26, 2026
370 checks passed
@bergarces bergarces deleted the correct-price-api-list branch May 26, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants